Skip to content

Add documentation for the MockClientStrategy #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2017
Merged

Add documentation for the MockClientStrategy #173

merged 3 commits into from
Feb 12, 2017

Conversation

samrap
Copy link

@samrap samrap commented Feb 7, 2017

See #90.

@samrap
Copy link
Author

samrap commented Feb 7, 2017

Please let me know if there are formatting errors here as I have never worked with rst.

@samrap samrap mentioned this pull request Feb 7, 2017
Merged
2 tasks
dbu
dbu approved these changes Feb 7, 2017
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very well written, thanks!

i see no mistakes. the only thing i would like to change is breaking lines after 80 characters. as long as there is no blank line between, line breaks are ignored by rst. this makes it easier to read the diff for small changes.

@samrap
Copy link
Author

samrap commented Feb 7, 2017

@dbu Updated!

@Nyholm
Copy link
Member

Nyholm commented Feb 12, 2017

Thanks

@Nyholm Nyholm merged commit 49dc8db into php-http:master Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samrap @Nyholm @dbu